fix(aws-logs): include new policy.ts exports in index.ts exports#17403
Conversation
|
|
peterwoodworth
left a comment
peterwoodworth
left a comment
There was a problem hiding this comment.
This PR got through because no tests were added which create a ResourcePolicy. Basic tests for this resource should be added
peterwoodworth
left a comment
peterwoodworth
left a comment
There was a problem hiding this comment.
I specifically meant a test which creates a ResourcePolicy directly as described in the docs https://docs.aws.amazon.com/cdk/api/latest/docs/aws-logs-readme.html#resource-policy
Ah gotcha. Done 👍🏻 |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
mergify
bot
deleted the
fix-new-resourcepolicy-construct-not-exported-from-index
branch
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…ws#17403) ## Summary This PR modifies the aws-logs `index.ts` file to also forward the exports from `policy.ts` ([a newly created file](aws#17015) that implements the `ResourcePolicy` class). Fixes: aws#17402 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
4 participants
Summary
This PR modifies the aws-logs
index.tsfile to also forward the exports frompolicy.ts(a newly created file that implements theResourcePolicyclass).Fixes: #17402
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license